Favourite model consistency

#1

Hi there,

Thanks for the free cat API ! :slight_smile:

After a few tests, looks like favourite model is not always constistent.

For example when listing all my favourites (GET favourites) a favourite looks like this:

{
    "created_at": "2018-10-26T05:40:32.000Z",
    "id": 915,
    "image": {
      "id": "11ByOV3dd",
      "url": "https://cdn2.thecatapi.com/images/11ByOV3dd.jpg"
    },
    "image_id": "11ByOV3dd",
    "sub_id": "demo-22f3fb",
    "user_id": "4"
}

But when i get a specific favourite (GET favourite/) the object looks like this

{
	"id": 915,
	"image_id": "11ByOV3dd",
	"sub_id": "demo-22f3fb",
	"user_id": "4"
}

We are missing created_at and image properties.

I’m patching this by rebuilding the model making an extra call to image object GET /images/{image_id}, but still, the created_at property is lost.

isn’t it planned to have a generic model ?

#2

Hey @cOdx, great spot!

As you suggested, ‘created_at’ and the Image object have been added to the /favourites/:id response

Let me know if you have any issues.

All the best, Aden